Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: kvserver: check PROSCRIBED lease status over UNUSABLE #102597

Merged
merged 2 commits into from May 9, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 28, 2023

Backport 2/2 commits from #102407 on behalf of @pavelkalinnikov.

/cc @cockroachdb/release


The PROSCRIBED lease status, just like EXPIRED, puts a lease to a definitely invalid state. The UNUSABLE state (when request timestamp is in stasis period) is less of a clear cut: we still own the lease but callers may use or not use it depending on context.

For example, the closed timestamp side-transport ignores the UNUSABLE state (because we still own the lease), and takes it as usable for its purposes. Because of the order in which the checks were made, this has lead to a bug: a PROSCRIBED lease is reported as UNUSABLE during stasis periods, the closed timestamp side-transport then considers it usable, and updates closed timestamps when it shouldn't.

This commit fixes the bug by swapping the order of checks in the leaseStatus method. The order now goes from "hard" checks like EXPIRED and PROSCRIBED, to "softer" UNUSABLE, and (when the softness is put to the limit) VALID.

Fixes #98698
Fixes #99931
Fixes #100101
Epic: none

Release note (bug fix): a bug is fixed in closed timestamp updates within its side-transport. Previously, during asymmetric partitions, a node that transfers a lease away, and misses a liveness heartbeat, could then erroneously update the closed timestamp during the stasis period of its liveness. This could lead to closed timestamp invariant violation, and node crashes; in extreme cases this could lead to inconsistencies in read-only queries.


Release justification: Fixes a correctness bug in closed timestamp side-transport

The PROSCRIBED lease status, just like EXPIRED, puts a lease to a definitely
invalid state. The UNUSABLE state (when request timestamp is in stasis period)
is less of a clear cut: we still own the lease but callers may use or not use
it depending on context.

For example, the closed timestamp side-transport ignores the UNUSABLE state
(because we still own the lease), and takes it as usable for its purposes.
Because of the order in which the checks were made, this has lead to a bug: a
PROSCRIBED lease is reported as UNUSABLE during stasis periods, the closed
timestamp side-transport then considers it usable, and updates closed
timestamps when it shouldn't.

This commit fixes the bug by swapping the order of checks in the leaseStatus
method. The order now goes from "hard" checks like EXPIRED and PROSCRIBED, to
"softer" UNUSABLE, and (when the softness is put to the limit) VALID.

Fixes #98698
Fixes #99931
Fixes #100101
Epic: none

Release note (bug fix): a bug is fixed in closed timestamp updates within its
side-transport. Previously, during asymmetric partitions, a node that transfers
a lease away, and misses a liveness heartbeat, could then erroneously update
the closed timestamp during the stasis period of its liveness. This could lead
to closed timestamp invariant violation, and node crashes; in extreme cases
this could lead to inconsistencies in read-only queries.
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 28, 2023 14:34
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 28, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-102407 branch from 53e82a8 to 8e85c73 Compare April 28, 2023 14:34
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Epic: none
Release note: none
@pav-kv pav-kv force-pushed the blathers/backport-release-22.1-102407 branch from 2b4f26d to e6f0bdb Compare May 9, 2023 12:57
@pav-kv pav-kv merged commit 9f6299c into release-22.1 May 9, 2023
5 of 6 checks passed
@pav-kv pav-kv deleted the blathers/backport-release-22.1-102407 branch May 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants