sql: add node ids and region to statement stats #102774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
14 tasks
1. Cache the list of node ids from the dist_sql_planner instance of
pasing the tracing statements. This improves the performance, and
allows ever request to track the information instead of just the
1% that have tracing enabled.
2. Cache the list of regions from the dist_sql_planner. This avoids
the overhead of looking up the region information again.
Epic: none
Fixes: 102170
Release note (sql change): Adds all node ids and regions used by a
statement to the statement statistics. Previously, only the gateway
node id and region were recorded.
|
Closing for a better implementation: #106587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: none
Fixes: #102170
Release note (sql change): Adds all node ids and regions used by a
statement to the statement statistics. Previously, only the gateway
node id and region were recorded.