Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: fix assignment casts of arrays #102811

Merged
merged 1 commit into from May 5, 2023

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented May 5, 2023

Backport 1/6 commits from #102491.

/cc @cockroachdb/release


sql: fix assignment casts of arrays

This commit fixes a bug that caused incorrect results for assignment
casts of array types. Previously, the array's elements were casted as an
explicit cast, not an assignment cast. This allowed values to be
inserted into an array column that did not conform to the type.

Fixes #102412

Release note (bug fix): A bug has been fixed that allowed values to be
inserted into an ARRAY-type column that did not conform to the
inner-type of the array. For example, it was possible to insert
ARRAY['foo'] into a column of type CHAR(1)[]. This could cause
incorrect results when querying the table. The insert now errors, which
is expected. This bug was present since v21.1.


Release justification: Fix for a correctness bug related to assignment
casts.

This commit fixes a bug that caused incorrect results for assignment
casts of array types. Previously, the array's elements were casted as an
explicit cast, not an assignment cast. This allowed values to be
inserted into an array column that did not conform to the type.

Fixes cockroachdb#102412

Release note (bug fix): A bug has been fixed that allowed values to be
inserted into an `ARRAY`-type column that did not conform to the
inner-type of the array. For example, it was possible to insert
`ARRAY['foo']` into a column of type `CHAR(1)[]`. This could cause
incorrect results when querying the table. The insert now errors, which
is expected. This bug was present since v21.1.
@mgartner mgartner requested review from michae2 and a team May 5, 2023 17:45
@mgartner mgartner requested a review from a team as a code owner May 5, 2023 17:45
@blathers-crl
Copy link

blathers-crl bot commented May 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner merged commit a50832e into cockroachdb:release-22.1 May 5, 2023
6 checks passed
@mgartner mgartner deleted the backport22.1-102491 branch May 5, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants