kvserverpb: mark probe requests' replicated cmds as IsTrivial #102953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
That way, they won't each request their own `replicaAppBatch`. They were wildly inefficient to apply before this commit, which played a role in a recent incident[^1]. [^1]: cockroachlabs/support#2287 Epic: none Release note: None
tbg
force-pushed
the
probes-are-trivial
branch
2 times, most recently
from
6ef1fb4
to
f207e49
Compare
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jun 6, 2023
This is the test used for cockroachdb#102953. Epic: none Release note: none
tbg
added
backport-22.2.x
backport-23.1.x
pav-kv
approved these changes
Jun 6, 2023
|
bors r=pavelkalinnikov |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from f207e49 to blathers/backport-release-22.2-102953: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jun 12, 2023
This is the test used for cockroachdb#102953. Epic: none Release note: none
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jun 20, 2023
This is the test used for cockroachdb#102953. Epic: none Release note: none
craig bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
104401: kvserver: add TestCreateManyUnappliedProbes r=pavelkalinnikov a=tbg This is the test used for #102953. This PR also makes modest progress on #75729, not by making log application stand-alone, but by making it somewhat less convoluted to manufacture log entries programmatically. It would be desirable to be able to test the replication layer in CRDB in the same way that Raft allows via the InteractionEnv[^1]. [^1]: https://github.com/etcd-io/raft/blob/6bf4f7fe3122b064e0a0d76314298dca6f379fc7/interaction_test.go Epic: none Release note: none 105083: kvcoord: Release catchup reservation before re-acquire attempt r=miretskiy a=miretskiy Release catchup scan reservation prior to attemt to re-acquire it. Failure to do so could result in a stuck mux rangefeed when enough ranges encounter an error, such as range split, prior to receiving the first checkpoint event, that would cause additional attempts to acquire catchup scan quota. Fixes #105058 Release note (bug fix): Fix a bug in mux rangefeed implementation that may cause mux rangefeed to become stuck if enough ranges encounter certain error concurrently. Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, they won't each request their own
replicaAppBatch. They were wildlyinefficient to apply before this commit, which played a (minor) role in a recent
incident1.
To validate this change, I ran an experiment that set up a range with 10 million unapplied probes. This PR more than halved how long it took to apply the entries.
Without this change:
With this change:
Touches https://github.com/cockroachlabs/support/issues/2287.
Closes #103905.
Epic: none
Release note: None
Footnotes
https://github.com/cockroachlabs/support/issues/2287 ↩