Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: include more non-redactable info in logs #103127

Merged
merged 1 commit into from
May 12, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented May 11, 2023

This patch ensures that the trace copy in replication errors includes non-redactable bits. It also ensures that the purgatory errors are properly included.

Release note: None
Epic: None

@knz knz added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels May 11, 2023
@knz knz requested review from tbg and aliher1911 May 11, 2023 17:58
@knz knz requested a review from a team as a code owner May 11, 2023 17:58
@blathers-crl
Copy link

blathers-crl bot commented May 11, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested a review from a team May 11, 2023 17:58
@knz knz force-pushed the 20230511-kvserver-errors branch from 59b282b to 1836e19 Compare May 11, 2023 19:05
Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@knz knz force-pushed the 20230511-kvserver-errors branch from 1836e19 to 964ac7e Compare May 12, 2023 11:22
This patch ensures that the trace copy in replication errors includes
non-redactable bits. It also ensures that the purgatory errors are
properly included.

Release note: None
@knz knz force-pushed the 20230511-kvserver-errors branch from 964ac7e to 7096f53 Compare May 12, 2023 11:22
@knz
Copy link
Contributor Author

knz commented May 12, 2023

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented May 12, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented May 12, 2023

Build succeeded:

@craig craig bot merged commit 2e2e5c1 into cockroachdb:master May 12, 2023
2 checks passed
@blathers-crl
Copy link

blathers-crl bot commented May 12, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7096f53 to blathers/backport-release-22.2-103127: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from 7096f53 to blathers/backport-release-23.1-103127: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants