Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: ui: no need to refresh page after error #103326

Merged
merged 1 commit into from May 16, 2023
Merged

release-22.1: ui: no need to refresh page after error #103326

merged 1 commit into from May 16, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 15, 2023 •
edited by maryliag

Backport 1/1 commits from #103240 on behalf of @maryliag.

/cc @cockroachdb/release

Previously, if one page crashes on DB Console, all other pages would show the same error message and the user had to force a refresh on the browser to be able to see the other pages. Now only the broken page shows the error and all the other pages load as expected. The user still needs to force a refresh on the broken page if they want to retry.

Fixes #97533

https://www.loom.com/share/56a6d811d9604b7abe673c1430ee605e

Release note (ui change): If a page crashed, a force refresh is no longer required to be able to see the other pages on DB Console.

Release justification: bug fix

@maryliag
ui: no need to refresh page after error
2f2b9c4 
Previously, if one page crashes on DB Console, all other
pages would show the same error message and the user had to
force a refresh on the browser to be able to see the other pages.
Now only the broken page shows the error and all the other pages
load as expected. The user still needs to force a refresh on
the broken page if they want to retry.

Fixes #97533

Release note (ui change): If a page crashed, a force refresh is
no longer required to be able to see the other pages on DB Console.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-103240 branch from 9f6299c to a48d6d6 Compare May 15, 2023 16:58
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label May 15, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-103240 branch from 1a3d42c to 2f2b9c4 Compare May 15, 2023 16:58
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label May 15, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented May 15, 2023 •
edited by maryliag

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from xinhaoz and a team May 15, 2023 16:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team May 15, 2023 17:09
koorosh
koorosh approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@maryliag maryliag merged commit 40f8dec into release-22.1 May 16, 2023
6 checks passed
@maryliag maryliag deleted the blathers/backport-release-22.1-103240 branch May 16, 2023 15:43
@cockroach-teamcity cockroach-teamcity mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koorosh koorosh koorosh approved these changes

@xinhaoz xinhaoz Awaiting requested review from xinhaoz

Assignees

@maryliag maryliag

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @koorosh @maryliag