New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: server, ui: more search criteria options on SQL Activity #104054
Conversation
Fixes #101817 More Options were added on Search Criteria for SQL Activity page. For top limit: 1000, 5000 and 10000. For Priority By On Statements page: - Last Execution Time - Max Latency - Max Memory - Min Latency - Network - P50 Latency - P90 Latency - Retries - Rows Processed For Priority By on Transactions page: - Max Memory - Network - Retries - Rows Processed It also fixes the sort on CPU that was sorting by the wrong column. Release note (ui change): On SQL Activity page add more Search Criteria options, by adding for "Top": 1000, 5000 and 10000. For "By" on Statements tab: - Last Execution Time, Max Latency, Max Memory, Min Latency, Network, P50 Latency, P90 Latency, Retries, Rows Processed. For "By" on Transactions tab: Max Memory, Network, Retries, Rows Processed. Release note (bug fix): Uses the correct column to sort by on CPU.
9921228
to
0fe053e
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
This is great! FYI @dongniwang @maryliag, can we add the 'None' option if it's not added already? It should be in figma and called out in the issue. TOP would be disabled. This would help solve the problem that users have when looking for a specific query - they don't need to go through all the options and do the search. |
This is a backport, so any new changes will be on a different PR. So for the "None" I didn't add it, because we always use one sort, and the default is by latency (which is what we were doing previously), so could be confusing a None that is actually doing a sort. We can discuss it offline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
Backport 1/1 commits from #103984 on behalf of @maryliag.
/cc @cockroachdb/release
Fixes #101817
More Options were added on Search Criteria for SQL Activity page.
For top limit: 1000, 5000 and 10000.
For Priority By On Statements page:
For Priority By on Transactions page:
It also fixes the sort on CPU that was sorting by the wrong column.
Release note (ui change): On SQL Activity page add more Search Criteria options, by adding for "Top": 1000, 5000 and 10000. For "By" on Statements tab: - Last Execution Time, Max Latency, Max Memory, Min Latency, Network, P50 Latency, P90 Latency, Retries, Rows Processed.
For "By" on Transactions tab: Max Memory, Network, Retries, Rows Processed.
Release note (bug fix): Uses the correct column to sort by on CPU.
Release justification: improvements to fix regression