Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server, ui: more search criteria options on SQL Activity #104054

Merged
merged 1 commit into from Jun 1, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 29, 2023

Backport 1/1 commits from #103984 on behalf of @maryliag.

/cc @cockroachdb/release


Fixes #101817

More Options were added on Search Criteria for SQL Activity page.
For top limit: 1000, 5000 and 10000.
Screenshot 2023-05-26 at 10 03 10 PM

For Priority By On Statements page:

  • Last Execution Time
  • Max Latency
  • Max Memory
  • Min Latency
  • Network
  • P50 Latency
  • P90 Latency
  • Retries
  • Rows Processed
Screenshot 2023-05-26 at 10 03 20 PM

For Priority By on Transactions page:

  • Max Memory
  • Network
  • Retries
  • Rows Processed
Screenshot 2023-05-26 at 10 03 36 PM

It also fixes the sort on CPU that was sorting by the wrong column.

Release note (ui change): On SQL Activity page add more Search Criteria options, by adding for "Top": 1000, 5000 and 10000. For "By" on Statements tab: - Last Execution Time, Max Latency, Max Memory, Min Latency, Network, P50 Latency, P90 Latency, Retries, Rows Processed.
For "By" on Transactions tab: Max Memory, Network, Retries, Rows Processed.
Release note (bug fix): Uses the correct column to sort by on CPU.


Release justification: improvements to fix regression

Fixes #101817

More Options were added on Search Criteria for SQL Activity
page.
For top limit: 1000, 5000 and 10000.

For Priority By On Statements page:
- Last Execution Time
- Max Latency
- Max Memory
- Min Latency
- Network
- P50 Latency
- P90 Latency
- Retries
- Rows Processed

For Priority By on Transactions page:
- Max Memory
- Network
- Retries
- Rows Processed

It also fixes the sort on CPU that was sorting by the wrong column.

Release note (ui change): On SQL Activity page add more Search
Criteria options, by adding for "Top": 1000, 5000 and 10000.
For "By" on Statements tab: - Last Execution Time, Max Latency,
Max Memory, Min Latency, Network, P50 Latency, P90 Latency, Retries,
Rows Processed.
For "By" on Transactions tab: Max Memory, Network, Retries, Rows
Processed.
Release note (bug fix): Uses the correct column to sort by on CPU.
@blathers-crl blathers-crl bot requested review from a team as code owners May 29, 2023 18:05
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 29, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103984 branch from 9921228 to 0fe053e Compare May 29, 2023 18:05
@blathers-crl
Copy link
Author

blathers-crl bot commented May 29, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag removed request for a team May 29, 2023 19:15
@kevin-v-ngo
Copy link

This is great! FYI @dongniwang

@maryliag, can we add the 'None' option if it's not added already? It should be in figma and called out in the issue. TOP would be disabled.

This would help solve the problem that users have when looking for a specific query - they don't need to go through all the options and do the search.

@maryliag
Copy link
Contributor

This is a backport, so any new changes will be on a different PR. So for the "None" I didn't add it, because we always use one sort, and the default is by latency (which is what we were doing previously), so could be confusing a None that is actually doing a sort. We can discuss it offline

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag maryliag merged commit 3e07121 into release-23.1 Jun 1, 2023
6 checks passed
@maryliag maryliag deleted the blathers/backport-release-23.1-103984 branch June 1, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants