release-22.2: opt: fix bug in RejectNullsProject #104073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #103611.
/cc @cockroachdb/release
opt: fix bug in RejectNullsProject
This commit fixes a bug in the
RejectNullsProject
rule that pushednull-rejecting filters below a Project expression for all projected
columns when any of the projected columns had null-rejecting filters
above the projections. In other words, it could incorrectly synthesize a
null-rejecting filter for a projected column, causing incorrect results.
Fixes #100561
Release note (bug fix): A bug has been fixed that could cause queries
with with joins or subqueries to omit rows where column values are NULL
in very rare cases. This bug was present since v20.2.
Release note: None
Release justification: Fixes a very rare but severe correctness bug.