Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: ui: add Rangefeed catchup charts #104122

Merged
merged 1 commit into from May 31, 2023
Merged

release-23.1: ui: add Rangefeed catchup charts #104122

merged 1 commit into from May 31, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 30, 2023 •
edited by koorosh

Backport 1/1 commits from #103927 on behalf of @koorosh.

/cc @cockroachdb/release

This change introduces two new charts on Changefeeds dashboard: "Ranges in catchup mode" and "RangeFeed catchup scans duration" that allow to detect disruptive scans after changefeeds restart.

Release note (ui change): added "Ranges in catchup mode" and "RangeFeed catchup scans duration" charts on Changefeeds dashboard.

Resolves: #97240

Screenshot 2023-05-26 at 00 02 50

Release justification: low risk, high benefit changes to existing functionality

@koorosh
ui: add Rangefeed catchup charts
428ad8b 
This change introduces two new charts on Changefeeds dashboard:
"Ranges in catchup mode" and "RangeFeed catchup scans duration" that
allow to detect disruptive scans after changefeeds restart.

Release note (ui change): added "Ranges in catchup mode" and
"RangeFeed catchup scans duration" charts on Changefeeds dashboard.
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 30, 2023 21:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103927 branch from d56c6ee to 6d57ace Compare May 30, 2023 21:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 30, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103927 branch from 7a02c65 to 428ad8b Compare May 30, 2023 21:36
@blathers-crl
Copy link
Author

blathers-crl bot commented May 30, 2023 •
edited by koorosh

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh merged commit c18783a into release-23.1 May 31, 2023
6 checks passed
@koorosh koorosh deleted the blathers/backport-release-23.1-103927 branch May 31, 2023 06:03
@cockroach-teamcity cockroach-teamcity mentioned this pull request Jun 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@maryliag maryliag Awaiting requested review from maryliag

Assignees

@koorosh koorosh

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @erikgrinaker @koorosh