Commits on May 31, 2023

1. storage: lock database before initializing encryption-at-rest …

   Previously, it was possible to corrupt the encryption-at-rest state of a store
   by running commands that manipulate store state without first terminating the
   store's Cockroach process. Cockroach uses a file lock to provide mutual
   exclusion between processes. Previously, this file lock was acquired when the
   Pebble engine was opened. The engine is opened only after the
   encryption-at-rest environment has been initialized, including rotating the
   file registry. This corruption required replacing the entire corrupted store.
   
   Fix an issue whereby encryption-at-rest disk state was not protectthe file lock
   that prevents
   
   Fix cockroachdb#98294.
   Release note (bug fix): Fix bug whereby running a debug command that
   manipulates a store (eg, `debug compact`) without first terminating the node
   using the store could result in corruption of the node's store if
   encryption-at-rest was enabled.

   

   jbowens committed May 31, 2023
   Copy the full SHA

   5ec7e50 View commit details

   Browse the repository at this point in the history