release-23.1: cli: default --include-range-info to true, but create a single file #104248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5/5 commits from #104133.
/cc @cockroachdb/release
Release justification: debug.zip improvement that avoids loss of observability after a recent change, and improves UX
This was introduced and defaulted to
false
in#102289.
Anecdotally I look at these in many L2 escalations1, and one cannot always
even change the default flag (e.g. CC), and seldom will a later debug.zip be
good enough for an RCA.
The original reason to introduce this flag seems to have been the delay
incurred when extracting these many files. There are suspicions that this
somehow exacerbates broken archives that we get from time to time, esp.
on large clusters.
This PR defaults the flag to true but also switches debug.zip so that it now
puts the ranges into a single file. This file is going to be large, but we can
handle that.
Epic: none
Release note: None
Footnotes
most recently today: https://github.com/cockroachlabs/support/issues/2343#issuecomment-1569677115 ↩