Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server, ui: don't recommend drop index to unique indexes #104287

Merged
merged 1 commit into from Jun 5, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 2, 2023

Backport 1/1 commits from #104270 on behalf of @maryliag.

/cc @cockroachdb/release


Previously, when an index was not being used we were recommending it to be dropped, and only if the index was primary, we would not recommend.
We should not be recommending to drop unique indexes, because even when they are not used for read, they're important for inserts and being dropped would change the schema of the table.

Part Of #104143

https://www.loom.com/share/b4e7fae3594944d09ec9af7e53bed7be

Release note (ui change): No longer show drop index recommendation for unique indexes.


Release justification: small change improvement

Previously, when an index was not being used we were
recommending it to be dropped, and only if the index was
primary, we would not recommend.
We should not be recommending to drop unique indexes, because
even when they are not used for read, they're important for
inserts and being dropped would change the schema of the table.

Part Of #104143

Release note (ui change): No longer show drop index recommendation
for unique indexes.
@blathers-crl blathers-crl bot requested review from a team as code owners June 2, 2023 22:16
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104270 branch from 8fdcc40 to 6b978cd Compare June 2, 2023 22:16
@blathers-crl blathers-crl bot requested review from a team as code owners June 2, 2023 22:16
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 2, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104270 branch from 2ff3c3d to ede8d93 Compare June 2, 2023 22:16
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 2, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag removed request for a team June 2, 2023 22:18
Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @THardy98)

@maryliag maryliag merged commit c79c32e into release-23.1 Jun 5, 2023
6 checks passed
@maryliag maryliag deleted the blathers/backport-release-23.1-104270 branch June 5, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants