New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: server, ui: don't recommend drop index to unique indexes #104287
Conversation
Previously, when an index was not being used we were recommending it to be dropped, and only if the index was primary, we would not recommend. We should not be recommending to drop unique indexes, because even when they are not used for read, they're important for inserts and being dropped would change the schema of the table. Part Of #104143 Release note (ui change): No longer show drop index recommendation for unique indexes.
8fdcc40
to
6b978cd
Compare
2ff3c3d
to
ede8d93
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @THardy98)
Backport 1/1 commits from #104270 on behalf of @maryliag.
/cc @cockroachdb/release
Previously, when an index was not being used we were recommending it to be dropped, and only if the index was primary, we would not recommend.
We should not be recommending to drop unique indexes, because even when they are not used for read, they're important for inserts and being dropped would change the schema of the table.
Part Of #104143
https://www.loom.com/share/b4e7fae3594944d09ec9af7e53bed7be
Release note (ui change): No longer show drop index recommendation for unique indexes.
Release justification: small change improvement