Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: avoid using shadowed index var to get sequence id #104297

Merged
merged 1 commit into from Jun 6, 2023
Merged

release-23.1: sql: avoid using shadowed index var to get sequence id #104297

merged 1 commit into from Jun 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 3, 2023 •
edited by chengxiong-ruan

Backport 1/1 commits from #104277 on behalf of @chengxiong-ruan.

/cc @cockroachdb/release

Fixes: #103869

This commit fixes a bug that shadowing index var was used featch sequence builtin function overload from a slice whose index was shadowed. This is very bad because it cause us to look at a overload accepting different number of params.

Release note (bug fix): this commit fixes a bug which would cause CREATE FUNCTION which uses setval builtin function to panic.

Release justification: low risk bug fix.

@chengxiong-ruan
sql: avoid using shadowed index var to get sequence id
05512a4 
Fixes: #103869

This commit fixes  a bug that shadowing index var was
used featch sequence builtin function overload from a slice
whose index was shadowed. This is very bad because it cause
us to look at a overload accepting different number of params.

Release note (bug fix): this commit fixes a bug which would
cause CREATE FUNCTION which uses `setval` builtin function
to panic.
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 3, 2023 12:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104277 branch from 819328a to 05512a4 Compare June 3, 2023 12:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 3, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan chengxiong-ruan merged commit 10f8875 into release-23.1 Jun 6, 2023
6 checks passed
@chengxiong-ruan chengxiong-ruan deleted the blathers/backport-release-23.1-104277 branch June 6, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@chengxiong-ruan chengxiong-ruan Awaiting requested review from chengxiong-ruan

Assignees

@chengxiong-ruan chengxiong-ruan

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @rafiss @chengxiong-ruan