Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/schemachanger: infrastructure for supporting CREATE statements #104348

Closed
wants to merge 2 commits into from

Commits on Jun 7, 2023

  1. sql/schemachanger: enforce one transition per-statement phase as a rule

    Previously, we had code inside the stage builder to enforce
    that only a single transition was allowed per-statement phase.
    This would have made it hard to implement CREATE statements
    since we need to apply multiple transitions. To address this,
    this patch adds dep rules to limit the number of transitions,
    which will be later disabled for create statements. To help
    support this a new precedence type is introduced.
    
    Epic: none
    Release note: None
    
    merge to 0
    <pkg>: <short description - lowercase, no final period>
    
    <what was there before: Previously, ...>
    <why it needed to change: This was inadequate because ...>
    <what you did about it: To address this, this patch ...>
    fqazi committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a5e68b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. sql/schemachanger: disable two version invariant for added descriptors

    Previously, the two version invariant was enforced
    for all non-dropped descriptors. When creating new
    descriptors if they are going to be decomposed into
    individual elements, then similar logic needs to
    skip added descriptors. To address this, this patch
    disables these rules for added descriptors.
    
    Epic: none
    
    Release note: None
    fqazi committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a202661 View commit details
    Browse the repository at this point in the history