New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: keyvisualizer: return error if delete query fails #104374
Conversation
resolves #103968 Epic: none Release note (bug fix): The keyvisualizer job no longer panics if an error is encountered while cleaning up stale samples. Instead, if the job encounters an error, the job will try again later.
6b81f53
to
3651575
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
9126e39
to
7130c0b
Compare
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out the backport criteria on the github comments.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag and @zachlite)
Backport 1/1 commits from #104286 on behalf of @zachlite.
/cc @cockroachdb/release
This commit returns the error produced from
DeleteSamplesBeforeTime
, if any. Before this change, an error would cause a panic, which is disruptive and unnecessary.The caller of this function returns errors produced to the job system, which will back off, and try again later. For more details, see Resume.
resolves #103968
Epic: none
Release note (bug fix): The keyvisualizer job no longer panics
if an error is encountered while cleaning up stale samples. Instead,
if the job encounters an error, the job will try again later.
Release justification: Low risk bug fix