Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: keyvisualizer: return error if delete query fails #104374

Merged
merged 1 commit into from Jun 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 5, 2023

Backport 1/1 commits from #104286 on behalf of @zachlite.

/cc @cockroachdb/release


This commit returns the error produced from DeleteSamplesBeforeTime, if any. Before this change, an error would cause a panic, which is disruptive and unnecessary.

The caller of this function returns errors produced to the job system, which will back off, and try again later. For more details, see Resume.

resolves #103968
Epic: none
Release note (bug fix): The keyvisualizer job no longer panics
if an error is encountered while cleaning up stale samples. Instead,
if the job encounters an error, the job will try again later.


Release justification: Low risk bug fix

resolves #103968
Epic: none
Release note (bug fix): The keyvisualizer job no longer panics
if an error is encountered while cleaning up stale samples. Instead,
if the job encounters an error, the job will try again later.
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 5, 2023 22:24
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104286 branch from 6b81f53 to 3651575 Compare June 5, 2023 22:24
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 5, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104286 branch from 9126e39 to 7130c0b Compare June 5, 2023 22:24
@blathers-crl blathers-crl bot requested a review from j82w June 5, 2023 22:24
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 5, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot requested review from maryliag and zachlite June 5, 2023 22:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the backport criteria on the github comments.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag and @zachlite)

@zachlite zachlite merged commit 3802101 into release-23.1 Jun 6, 2023
6 checks passed
@zachlite zachlite deleted the blathers/backport-release-23.1-104286 branch June 6, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants