ui: add Networking metrics dashboard #104394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This has cockroachdb#99191 as a prerequisite. This moves a few existing network-related metrics to their own dashboard. It also adds metrics for healthy and unhealthy connections, which are now more functional thanks to the work on the RPC package carried out in the previous commits. Epic: None Release note (ui change): the DB Console metrics dashboard now has a "Networking" tab, and a few metrics previously displayed on the Hardware tab have moved there.
koorosh
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier)
|
bors r=koorosh |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r=koorosh |
|
bors r- |
|
Canceled. |
|
bors single on |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has #99191 as a prerequisite.
This moves a few existing network-related metrics to their own dashboard. It
also adds metrics for healthy and unhealthy connections, which are now more
functional thanks to the work on the RPC package carried out in the previous
commits.
Epic: None
Release note (ui change): the DB Console metrics dashboard now has a
"Networking" tab, and a few metrics previously displayed on the Hardware tab
have moved there.