New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: upgrades: batch the job_info backfill upgrade #104574
Conversation
Release note (bug fix): The backfill of system.job_info upgrade migration that runs during upgrades from 22.2 now processes rows in batches to avoid cases where it could become stuck due to contention and transaction retries. Epic: none.
dcffb6a
to
cdedbc6
Compare
7f684f3
to
553c2e6
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For other reviewers: I believe that the batching here is correct even in the face of other writes into system.jobs because we are double-writing into both the system.jobs and job_info table at this point.
I'm not sure I appreciate how the dual-writes interacts with batching or not batching ? |
Backport 1/1 commits from #104545 on behalf of @dt.
/cc @cockroachdb/release
Release note (bug fix): The backfill of system.job_info upgrade migration that runs during upgrades from 22.2 now processes rows in batches to avoid cases where it could become stuck due to contention and transaction retries.
Epic: none.
Release justification: high impact bug fix that prevents stuck upgrades because of txn contention