Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: show alert on DB Console overview when upgrade is not finalized #104874

Merged
merged 2 commits into from Jun 15, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 14, 2023

Backport 1/1 commits from #104688 on behalf of @maryliag.

/cc @cockroachdb/release


Display a warning on the DB Console overview page when all the nodes are running on the new version, but the cluster is not finalized.

Fixes #66987

Screenshot 2023-06-09 at 5 29 01 PM

Example of cluster with a not finalized upgrade, and the values being used on this PR to compare:
https://www.loom.com/share/1d478f69ea0f459fbdc3d1506f5a8dfc

Release note (ui change): Add warning to DB Console overview page when all nodes are running on the new version, but the cluster upgrade is not finalized.


Release justification: small change, big impact

Display a warning on the DB Console overview page when all
the nodes are running on the new version, but the cluster
is not finalized.

Fixes #66987

Release note (ui change): Add warning to DB Console overview page
when all nodes are running on the new version, but the cluster
upgrade is not finalized.
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 14, 2023 13:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104688 branch from 89d3f29 to 265b706 Compare June 14, 2023 13:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 14, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104688 branch from d221ef9 to 8c90351 Compare June 14, 2023 13:56
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 14, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @florence-crl, @maryliag, and @rafiss)

@maryliag maryliag merged commit e258bb7 into release-23.1 Jun 15, 2023
6 checks passed
@maryliag maryliag deleted the blathers/backport-release-23.1-104688 branch June 15, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants