logic: keep cockroach-go logs in case of failure #104876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
renatolabs
force-pushed
the
rc/save-cockroach-go-logs-on-failure
branch
2 times, most recently
from
bb57c78
to
406ac73
Compare
rafiss
approved these changes
Jun 14, 2023
pkg/sql/logictest/logic.go
Outdated
| @@ -1287,6 +1300,7 @@ func (t *logicTest) newTestServerCluster(bootstrapBinaryPath string, upgradeBina | |||
| t.clusterCleanupFuncs = append(t.clusterCleanupFuncs, ts.Stop) | |||
There was a problem hiding this comment.
nit: as long as the cleanupFuncs are being added here, should we just have your new callback get appended here too, rather than returning it. either way, it seems better to be consistent either append both cleanupFunctions here, or to the ts.Stop call in the returned function.
There was a problem hiding this comment.
Right, I don't know what I was thinking. Fixed.
This commit makes use of the new `CockroachLogsDirOpt` option introduced in [1] to pass a custom directory where cockroach logs will be stored. This directory is relative to TMPDIR, which is part of the artifacts path when the test runs in CI. With this change, when a logic test using the cockroach-go config fails, we'll be able to see both the test logs as well as the cockroach logs themselves. The latter will be in the `cockroach.stderr` file. [1] cockroachdb/cockroach-go#170 Epic: none Release note: None
renatolabs
force-pushed
the
rc/save-cockroach-go-logs-on-failure
branch
from
406ac73
to
8069f3a
Compare
|
TFTR! bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes use of the new
CockroachLogsDirOptoption introduced in [1] to pass a custom directory where cockroach logs will be stored. This directory is relative to TMPDIR, which is part of the artifacts path when the test runs in CI. With this change, when a logic test using the cockroach-go config fails, we'll be able to see both the test logs as well as the cockroach logs themselves. The latter will be in thecockroach.stderrfile.[1] cockroachdb/cockroach-go#170
Epic: none
Release note: None