Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: changefeedccl: add version gate to SHOW CHANGEFEED JOBS #105008

Merged

Conversation

jayshrivastava
Copy link
Contributor

@jayshrivastava jayshrivastava commented Jun 15, 2023

Backport 1/1 commits from #104986.

/cc @cockroachdb/release


On 23.1 binaries, SHOW CHANGEFEED JOBS queries crdb_internal.system_jobs, which was added in 23.1. In 22.2-23.1 mixed version clusters, this query fails.

This change adds a version gate such that before an upgrade to 23.1 is finalized, SHOW CHANGEFEED JOBS will query system.jobs instead.

This change also adds regression testing in the changefeed logic test, ensuring that it runs in a mixed version environment.

Release note (bug fix): SHOW CHANGEFEED JOBS no
longer fails on 22.2, 23.1 mixed version clusters.

Epic: None
Release justification: Bug fix.

@blathers-crl
Copy link

blathers-crl bot commented Jun 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

On 23.1 binaries, `SHOW CHANGEFEED JOBS` queries `crdb_internal.system_jobs`,
which was added in 23.1. In 22.2-23.1 mixed version clusters, this query fails.

This change adds a version gate such that before an upgrade to 23.1 is finalized,
`SHOW CHANGEFEED JOBS` will query `system.jobs` instead.

This change also adds regression testing in the `changefeed` logic test, ensuring
that it runs in a mixed version environment.

Release note (bug fix): `SHOW CHANGEFEED JOBS` no
longer fails on 22.2, 23.1 mixed version clusters.

Epic: None
@jayshrivastava jayshrivastava marked this pull request as ready for review June 15, 2023 21:35
@jayshrivastava jayshrivastava requested a review from a team as a code owner June 15, 2023 21:35
@jayshrivastava jayshrivastava merged commit 686eaf0 into cockroachdb:release-23.1 Jun 21, 2023
6 checks passed
@jayshrivastava jayshrivastava deleted the backport23.1-104986 branch June 21, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants