Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: privilege: don't include NOSQLLOGIN in ALL check #105080

Merged
merged 1 commit into from Jun 21, 2023
Merged

release-23.1: privilege: don't include NOSQLLOGIN in ALL check #105080

merged 1 commit into from Jun 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 16, 2023 •
edited by rafiss

Backport 1/1 commits from #104685 on behalf of @rafiss.

/cc @cockroachdb/release

fixes #101292

Release note (bug fix): GRANT SYSTEM ALL ... no longer causes the grantee to be unable to login. This was due to a UX oversight/bug where ALL would include the NOSQLLOGIN system privilege. Since NOSQLLOGIN is the only "negative" privilege, it is now excluded from the ALL shorthand, and must be granted explicitly in order to restrict logins.

Release justification: bug fix

@rafiss
privilege: don't include NOSQLLOGIN in ALL check
5f2e3d3 
Release note (bug fix): GRANT SYSTEM ALL ... no longer causes the
grantee to be unable to login. This was due to a UX oversight/bug where
ALL would include the NOSQLLOGIN system privilege. Since NOSQLLOGIN is
the only "negative" privilege, it is now excluded from the ALL
shorthand, and must be granted explicitly in order to restrict logins.
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 16, 2023 20:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104685 branch from c93080b to ee5e9b3 Compare June 16, 2023 20:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 16, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104685 branch from 51cdde2 to 5f2e3d3 Compare June 16, 2023 20:56
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 16, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from ecwall and rafiss June 16, 2023 20:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss removed their request for review June 20, 2023 14:23
@rafiss rafiss merged commit 8f0fbc4 into release-23.1 Jun 21, 2023
6 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.1-104685 branch June 21, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecwall ecwall ecwall approved these changes

Assignees

@rafiss rafiss

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @ecwall @rafiss