New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: rename RaftMessageHandler to IncomingRaftMessageHandler #105123
Conversation
029a7a8
to
35676af
Compare
6a60f67
to
05c794f
Compare
I’m putting the PR merging on hold until we settle down the discussion on renaming for Listen and Stop. Update: decided to just rename Listen and Stop as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @wenyihu6)
The commit renames `RaftMessageHandler`, `Listen`, and `Stop` to `IncomingRaftMessageHandler`, `ListenIncomingRaftMessages`, and `StopIncomingRaftMessages`. Another PR is introducing a new interface `OutgoingRaftMessageHandler`, dedicated to managing messages sent. The main purpose of this PR is to make the future PR cleaner by handling the renaming process. Note that this commit does not change any existing functionality. Part of: cockroachdb#103983 Related: cockroachdb#105122 Release Note: None
TFTRs!! bors r=tbg,kvoli |
Build succeeded: |
The commit renames
RaftMessageHandler
,Listen
, andStop
toIncomingRaftMessageHandler
,ListenIncomingRaftMessages
, andStopIncomingRaftMessages
. Another PR is introducing a new interfaceOutgoingRaftMessageHandler
, dedicated to managing messages sent. The mainpurpose of this PR is to make the future PR cleaner by handling the renaming
process. Note that this commit does not change any existing functionality.
Part of: #103983
Related: #105122
Release Note: None