New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: sqlstats: fix metadata column in system.transaction_activity
#105318
Conversation
Previously, the metadata column in `system.transaction_activity` was being incorrectly written as a the aggregated metadata type for statements. This occurs due to using `crdb_internal.merge_stats_metadata` function when this function only applies to stmt metadata. This bug meant that the UI did not have access to the txn metadata when querying from `system.transaction_activity` which contains the in-order stmt fingerprints for the txn that is used to build the txn query. Thus the txn query was showing as unavailable for all txns from this table. As part of this change, the sql activity updater job will get its AOST clause from its newly added sqlstats testing knobs field to make testing simpler. Fixes: #103618 Release note (bug fix): On the sql stats pages, the txn query should be available so long as the stmt fingerprints associated with the txn also exist in the payload. In other words the majority of txns should have the txn query available when selecting a recent time period.
4593f0d
to
cc55432
Compare
07503a7
to
056d2fe
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
Backport 1/1 commits from #104621 on behalf of @xinhaoz.
/cc @cockroachdb/release
Previously, the metadata column in
system.transaction_activity
was being incorrectly written as a the aggregated metadata type for statements. This occurs due to usingcrdb_internal.merge_stats_metadata
function when this function only applies to stmt metadata. This bug meant that the UI did not have access to the txn metadata when querying fromsystem.transaction_activity
which contains the in-order stmt fingerprints for the txn that is used to build the txn query. Thus the txn query was showing as unavailable for all txns from this table.As part of this change, the sql activity updater job will get its AOST clause from its newly added sqlstats testing knobs field to make testing simpler.
Fixes: #103618
Release note (bug fix): On the sql stats pages, the txn query should be available so long as the stmt fingerprints associated with the txn also exist in the payload. In other words the majority of txns should have the txn query available when selecting a recent time period.
Release justification: bug fix