Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sqlstats: fix metadata column in system.transaction_activity #105318

Merged
merged 1 commit into from Jun 22, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 21, 2023

Backport 1/1 commits from #104621 on behalf of @xinhaoz.

/cc @cockroachdb/release


Previously, the metadata column in system.transaction_activity was being incorrectly written as a the aggregated metadata type for statements. This occurs due to using crdb_internal.merge_stats_metadata function when this function only applies to stmt metadata. This bug meant that the UI did not have access to the txn metadata when querying from system.transaction_activity which contains the in-order stmt fingerprints for the txn that is used to build the txn query. Thus the txn query was showing as unavailable for all txns from this table.

As part of this change, the sql activity updater job will get its AOST clause from its newly added sqlstats testing knobs field to make testing simpler.

Fixes: #103618

Release note (bug fix): On the sql stats pages, the txn query should be available so long as the stmt fingerprints associated with the txn also exist in the payload. In other words the majority of txns should have the txn query available when selecting a recent time period.


Release justification: bug fix

Previously, the metadata column in `system.transaction_activity` was
being incorrectly written as a the aggregated metadata type for
statements. This occurs due to using `crdb_internal.merge_stats_metadata`
function when this function only applies to stmt metadata. This bug
meant that the UI did not have access to the txn metadata when querying
from `system.transaction_activity` which contains the in-order stmt
fingerprints for the txn that is used to build the txn query. Thus the
txn query was showing as unavailable for all txns from this table.

As part of this change, the sql activity updater job will get its
AOST clause from its newly added sqlstats testing knobs field to make
testing simpler.

Fixes: #103618

Release note (bug fix): On the sql stats pages, the txn query should
be available so long as the stmt fingerprints associated with the txn
also exist in the payload. In other words the majority of txns should
have the txn query available when selecting a recent time period.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104621 branch from 4593f0d to cc55432 Compare June 21, 2023 21:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 21, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104621 branch from 07503a7 to 056d2fe Compare June 21, 2023 21:58
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 21, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@xinhaoz xinhaoz merged commit 687df7f into release-23.1 Jun 22, 2023
5 of 6 checks passed
@xinhaoz xinhaoz deleted the blathers/backport-release-23.1-104621 branch June 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants