Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: go.mod: bump Pebble to b71662e4900e #105361

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Jun 22, 2023

b71662e4 db: don't require holding d.mu to read format major version

Epic: none
Release note (bug fix): Fix a source of mutex contention within the storage engine that could increase tail latencies on high-CPU, high-throughput deployments.
Release justification: Low-risk fix to contributor of high tail latencies observed in customer clusters.

@jbowens jbowens requested review from a team and RaduBerinde June 22, 2023 16:42
@jbowens jbowens requested a review from a team as a code owner June 22, 2023 16:42
@blathers-crl
Copy link

blathers-crl bot commented Jun 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens force-pushed the jackson/pebble-release-23.1-b71662e4900e branch from 1ec4016 to 9c86141 Compare June 22, 2023 17:45
@jbowens jbowens requested a review from a team as a code owner June 22, 2023 17:45
@jbowens jbowens force-pushed the jackson/pebble-release-23.1-b71662e4900e branch from 9c86141 to 812ffb5 Compare June 22, 2023 17:47
```
b71662e4 db: don't require holding d.mu to read format major version
```

Epic: none
Release note (bug fix): Fix a source of mutex contention within the storage
engine that could increase tail latencies on high-CPU, high-throughput deployments.
@jbowens jbowens force-pushed the jackson/pebble-release-23.1-b71662e4900e branch from 812ffb5 to 71aac17 Compare June 22, 2023 18:43
@jbowens jbowens removed the request for review from a team June 22, 2023 18:43
@jbowens
Copy link
Collaborator Author

jbowens commented Jun 22, 2023

TFTR!

@jbowens jbowens merged commit 9556895 into cockroachdb:release-23.1 Jun 22, 2023
6 checks passed
@jbowens jbowens deleted the jackson/pebble-release-23.1-b71662e4900e branch June 22, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants