Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: opt: skip uniqueness check for STRING and BYTES cols with gen_random_uuid() #105446

Merged
merged 1 commit into from Jun 27, 2023
Merged

release-23.1: opt: skip uniqueness check for STRING and BYTES cols with gen_random_uuid() #105446

merged 1 commit into from Jun 27, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 23, 2023 •
edited by rytaft

Backport 1/1 commits from #105395 on behalf of @rytaft.

/cc @cockroachdb/release

Fixes #104550

Release note (performance improvement): If the cluster setting sql.optimizer.uniqueness_checks_for_gen_random_uuid.enabled is disabled, the optimizer can now eliminate uniqueness checks for STRING and BYTES columns when the value is set to gen_random_uuid() (with an implicit or explicit cast to STRING or BYTES). If users still want the checks, they can set sql.optimizer.uniqueness_checks_for_gen_random_uuid.enabled to true (the default is false).

Release justification: low-risk improvement to existing functionality needed by a customer

@rytaft
opt: skip uniqueness check for STRING and BYTES cols with gen_random_…
a881bbf 
…uuid()

Fixes #104550

Release note (performance improvement): If the cluster setting
sql.optimizer.uniqueness_checks_for_gen_random_uuid.enabled is disabled,
the optimizer can now eliminate uniqueness checks for STRING and BYTES columns
when the value is set to gen_random_uuid() (with an implicit or explicit
cast to STRING or BYTES). If users still want the checks, they can set
sql.optimizer.uniqueness_checks_for_gen_random_uuid.enabled to true (the
default is false).
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 23, 2023 17:24
@blathers-crl blathers-crl bot requested a review from cucaroach June 23, 2023 17:24
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105395 branch from 296dfd2 to 43002b4 Compare June 23, 2023 17:24
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 23, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-105395 branch from b62f5f9 to a881bbf Compare June 23, 2023 17:24
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 23, 2023 •
edited by rytaft

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rytaft rytaft merged commit 534c560 into release-23.1 Jun 27, 2023
6 checks passed
@rytaft rytaft deleted the blathers/backport-release-23.1-105395 branch June 27, 2023 02:45
@cockroach-teamcity cockroach-teamcity mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@msirek msirek msirek approved these changes

@cucaroach cucaroach Awaiting requested review from cucaroach cucaroach was automatically assigned from cockroachdb/sql-queries

@rytaft rytaft Awaiting requested review from rytaft

Assignees

@rytaft rytaft

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cockroach-teamcity @mgartner @msirek @rytaft