Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: disallow cross-database type references in CTAS #105619

Merged
merged 1 commit into from Jun 27, 2023
Merged

release-22.2: sql: disallow cross-database type references in CTAS #105619

merged 1 commit into from Jun 27, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 27, 2023 •
edited by chengxiong-ruan

Backport 1/1 commits from #105579 on behalf of @chengxiong-ruan.

/cc @cockroachdb/release

Fixes: #105393

Release note (bug fix): reviously, cross-database type references could sneaked in through CREATE TABLE...AS statements if the source table is from another database and any of its columns is of a user defined type. This introduced bug where the source table can be dropped and type could not be found for the CTAS table. This commit disallow such CTAS as a fix.

Release justification: low risk bug fix

@blathers-crl blathers-crl bot requested a review from a team as a code owner June 27, 2023 14:49
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-105579 branch from dec998c to df398f3 Compare June 27, 2023 14:49
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 27, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-105579 branch from 7ddae9b to 39176d3 Compare June 27, 2023 14:49
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from postamar June 27, 2023 14:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan
sql: disallow cross-database type references in CTAS
dfc09d4 
Fixes: #105393

Release note (bug fix): reviously, cross-database type references
could sneaked in through `CREATE TABLE...AS` statements if the
source table is from another database and any of its columns is of
a user defined type. This introduced bug where the source table
can be dropped and type could not be found for the CTAS table.
This commit disallow such CTAS as a fix.
@chengxiong-ruan chengxiong-ruan force-pushed the blathers/backport-release-22.2-105579 branch from 39176d3 to dfc09d4 Compare June 27, 2023 17:53
@chengxiong-ruan chengxiong-ruan merged commit c3cb4ba into release-22.2 Jun 27, 2023
6 checks passed
@chengxiong-ruan chengxiong-ruan deleted the blathers/backport-release-22.2-105579 branch June 27, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

Assignees

@chengxiong-ruan chengxiong-ruan

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @postamar @chengxiong-ruan