Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server: deflake test hot ranges response #105879

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Jun 30, 2023

Backport 1/1 commits from #99108.

/cc @cockroachdb/release


Flaky tests for HotRanges api were caused after changing source
for getting stats per replica in mapToHotReplicasInfo func.
mapToHotReplicasInfo func calls Repl().LoadStats() that
internally relies on calculates average values per second
in current moment, but values could be recorded earlier.

Now, mapToHotReplicasInfo func relies on RangeUsageInfo() func
that keeps average stats at the time stats were recorded.

Related change to this fix: #99716

Release note: None

Fixes: #98619

Release justification: non-production code changes

Flaky tests for HotRanges api were caused after changing source
for getting stats per replica in `mapToHotReplicasInfo` func.
`mapToHotReplicasInfo` func calls `Repl().LoadStats()` that
internally relies on calculating averages on each function call.

Now, `mapToHotReplicasInfo` func relies on `RangeUsageInfo()` func
that keeps average stats at the time stats were recorded.

In addition, tests validate that QPS should be greater that zero
if both write/read keys and write/read bytes stats are non-zero.

Release note: None
@koorosh koorosh requested a review from a team as a code owner June 30, 2023 10:43
@koorosh koorosh requested a review from a team June 30, 2023 10:43
@koorosh koorosh requested a review from a team as a code owner June 30, 2023 10:43
@blathers-crl
Copy link

blathers-crl bot commented Jun 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@koorosh koorosh requested review from nkodali and removed request for a team June 30, 2023 10:43
@blathers-crl
Copy link

blathers-crl bot commented Jun 30, 2023

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jun 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh removed the O-community Originated from the community label Jun 30, 2023
@koorosh koorosh requested review from kvoli, maryliag, zachlite, j82w, THardy98, xinhaoz and gtr and removed request for nkodali June 30, 2023 10:55
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @gtr, @j82w, @kvoli, @THardy98, @xinhaoz, and @zachlite)

@koorosh koorosh merged commit dfb4e43 into cockroachdb:release-23.1 Jul 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants