New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: populate information_schema.routines and parameters #105944
Conversation
4503170
to
73ae425
Compare
73ae425
to
4cb887d
Compare
This adds the nameconcatoid in order to match PostgreSQL. It is used by the information_schema to create unique names. Release note (sql change): Added the nameconcatoid builtin function, which concatenates a name with an OID.
Release note (sql change): The pg_catalog.pg_language table is now populated with data about languages used to define functions.
Release note (sql change): The information_schema.routines view is now populated with information about functions.
Add an implementation for pg_get_function_arg_default to match PostgreSQL. Since we don't support function defaults, this always returns NULL. Release note: None
Release note (sql change): The information_schema.parameters table is now populated with information about function parameters.
4cb887d
to
6e1de01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, 3 of 3 files at r2, 3 of 3 files at r3, 3 of 3 files at r4, 7 of 7 files at r5, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
ty! bors r+ |
Build succeeded: |
Not sure how important this is, but on my laptop I have a different OID for the PLpgSQL language:
|
fixes #104083
builtins: add nameconcatoid function
This adds the nameconcatoid in order to match PostgreSQL. It is used by
the information_schema to create unique names.
Release note (sql change): Added the nameconcatoid builtin function,
which concatenates a name with an OID.
sql: populate pg_catalog.pg_language
Release note (sql change): The pg_catalog.pg_language table is now
populated with data about languages used to define functions.
sql: implement information_schema.routines view
Release note (sql change): The information_schema.routines view is now
populated with information about functions.
builtins: add pg_get_function_arg_default
Add an implementation for pg_get_function_arg_default to match
PostgreSQL. Since we don't support function defaults, this always
returns NULL.
Release note: None
sql: populate information_schema.parameters
Release note (sql change): The information_schema.parameters table is
now populated with information about function parameters.