kvserver: deflake all tests that restart test cluster servers #106145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
TestSnapshotAfterTruncation
branch
2 times, most recently
from
e36e0c2
to
635ec97
Compare
tbg
changed the title
We'll want to access it from `base`, which can't import `testutils` due to dependency cycles.
We'll type assert on it in future commits.
Future commits will change the receiver to ReusableListener.
We'll clean up the possible confusion with `GetOrFail` (which will create the listener if not present) later.
This will replace the ReusableListeners flag and simplify all tests using it. It's not used as of this commit, and all the tests using the soon-to-be-legacy approach still pass.
They didn't do this before, and as a result were susceptible to flakes. They were discovered through the checks introduced in follow-up commits. It will be impossible to hold it wrong.
tbg
force-pushed
the
TestSnapshotAfterTruncation
branch
from
635ec97
to
4e8a998
Compare
erikgrinaker
approved these changes
Jul 13, 2023
|
TFTR! bors r=erikgrinaker |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 5f4496b to blathers/backport-release-23.1-106145: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks how TestCluster's reusable listeners work. They are now enforced in tests that restart servers under the same listening address, since restarting without one opens the door to a race where the port is now assigned to another process.
The 23.1 backport will address #105940.
Epic: None
Release note: None