Revert "Revert "storage: use size-carrying point tombstones"" #106177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 90c1ee6. Epic: CRDB-25405 Release note (performance improvement): Improve disk space reclamation heuristics making disk space reclamation more timely.
jbowens
requested review from
herkolategan,
renatolabs and
sumeerbhola
and removed request for
a team
|
This change is |
|
TFTR! bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 90c1ee6.
The corruption issue surfaced by this commit was a bug within a feature enabled by the sstable format used within the commit. This feature has been disabled and the bug is tracked cockroachdb/pebble#2705.
Epic: CRDB-25405
Release note (performance improvement): Improve disk space reclamation heuristics making disk space reclamation more timely.