Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: allocator: expose LeaseRebalanceThreshold as a cluster setting #106186

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Jul 5, 2023

Backport 1/1 commits from #105924.

/cc @cockroachdb/release


This patch adds a new cluster setting --
kv.allocator.lease_rebalance_threshold. This setting controls the minimum
fraction away from the mean a store's lease count can be before it is considered
for lease-transfers. The default setting is 0.05.

Fixes: #105909

Release Note (allocator): cluster setting
kv.allocator.lease_rebalance_threshold can now be used to control the minimum
fraction away from the mean a store's lease count before it is considered for
lease-transfers. The default setting is 0.05.


Release justification: low risk to the existing functionality

@blathers-crl
Copy link

blathers-crl bot commented Jul 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@wenyihu6
Copy link
Contributor Author

wenyihu6 commented Jul 5, 2023

Same comment from the previous PR - non-trivial backport to the 22.2 branch due to the absence of the cluster setting field on the allocator. Happy to close this PR if the change is considered substantial.

Would appreciate a second pair of eyes on adding the cluster setting field to the allocator. Most of the changes were made by just observing the existing pattern observed on the master branch.

@wenyihu6 wenyihu6 marked this pull request as ready for review July 5, 2023 17:00
@wenyihu6 wenyihu6 requested a review from a team as a code owner July 5, 2023 17:00
@wenyihu6 wenyihu6 requested a review from kvoli July 5, 2023 17:26
@wenyihu6 wenyihu6 self-assigned this Jul 5, 2023
Copy link
Collaborator

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Are you going to squash the first commit into the second before merging?

Reviewed 6 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @wenyihu6)

This patch adds a new cluster setting --
`kv.allocator.lease_rebalance_threshold`. This setting controls the minimum
fraction away from the mean a store's lease count can be before it is considered
for lease-transfers. The default setting is 0.05.

Fixes: cockroachdb#105909

Release Note (allocator): cluster setting
`kv.allocator.lease_rebalance_threshold` can now be used to control the minimum
fraction away from the mean a store's lease count before it is considered for
lease-transfers. The default setting is 0.05.
@wenyihu6
Copy link
Contributor Author

wenyihu6 commented Jul 10, 2023

:lgtm:

Are you going to squash the first commit into the second before merging?

Reviewed 6 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @wenyihu6)

Yeah. Just squashed them.

@wenyihu6 wenyihu6 merged commit 92136d9 into cockroachdb:release-22.2 Jul 10, 2023
6 checks passed
@wenyihu6 wenyihu6 deleted the backport22.2-105924 branch July 10, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants