-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: allocator: expose LeaseRebalanceThreshold as a cluster setting #106186
release-22.2: allocator: expose LeaseRebalanceThreshold as a cluster setting #106186
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Same comment from the previous PR - non-trivial backport to the 22.2 branch due to the absence of the cluster setting field on the allocator. Happy to close this PR if the change is considered substantial. Would appreciate a second pair of eyes on adding the cluster setting field to the allocator. Most of the changes were made by just observing the existing pattern observed on the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to squash the first commit into the second before merging?
Reviewed 6 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @wenyihu6)
This patch adds a new cluster setting -- `kv.allocator.lease_rebalance_threshold`. This setting controls the minimum fraction away from the mean a store's lease count can be before it is considered for lease-transfers. The default setting is 0.05. Fixes: cockroachdb#105909 Release Note (allocator): cluster setting `kv.allocator.lease_rebalance_threshold` can now be used to control the minimum fraction away from the mean a store's lease count before it is considered for lease-transfers. The default setting is 0.05.
c8002d5
to
5c8c402
Compare
Yeah. Just squashed them. |
Backport 1/1 commits from #105924.
/cc @cockroachdb/release
This patch adds a new cluster setting --
kv.allocator.lease_rebalance_threshold
. This setting controls the minimumfraction away from the mean a store's lease count can be before it is considered
for lease-transfers. The default setting is 0.05.
Fixes: #105909
Release Note (allocator): cluster setting
kv.allocator.lease_rebalance_threshold
can now be used to control the minimumfraction away from the mean a store's lease count before it is considered for
lease-transfers. The default setting is 0.05.
Release justification: low risk to the existing functionality