Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: cloud,backupccl: path does not contain a completed latest backup (emp… #106235

Merged
merged 1 commit into from Aug 1, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 6, 2023

Backport 1/1 commits from #106074 on behalf of @srosenberg.

/cc @cockroachdb/release


…ty objects ending with /)

Third-party services, e.g., AWS DataSync insert empty objects with a trailing / (to denote folders). Thus, a bucket containing backups which was transferred via AWS DataSync cannot be restored.
Previously, restore would fail with the follwing
error message, read LATEST path: path does not contain a completed latest backup: NoSuchKey.

This change skips over the empty object while enumerating the objects in the LatestHistoryDirectory.

Epic: none
Fixes: #106070

Release note (bug fix): cloud buckets containing backups can now be copied via AWS DataSync and other third-party services which insert empty object with a trailing /. Previously, restore would fail with the follwing error message, read LATEST path: path does not contain a completed latest backup: NoSuchKey.


Release justification: bug fix

…ty objects ending with /)

Third-party services, e.g., AWS DataSync insert empty objects with a
trailing `/` (to denote folders). Thus, a bucket containing backups which was
transferred via AWS DataSync cannot be restored.
Previously, restore would fail with the follwing
error message, `read LATEST path: path does not contain a completed latest backup: NoSuchKey`.

This change skips over the empty object while enumerating the objects in the
`LatestHistoryDirectory`.

Epic: none
Fixes: #106070

Release note (bug fix): cloud buckets containing backups can now be copied
via AWS DataSync and other third-party services which insert empty
object with a trailing `/`. Previously, restore would fail with the follwing
error message, `read LATEST path: path does not contain a completed latest backup: NoSuchKey`.
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 6, 2023 00:35
@blathers-crl blathers-crl bot requested review from adityamaru and removed request for a team July 6, 2023 00:35
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106074 branch from fa2d7f7 to a335ed7 Compare July 6, 2023 00:35
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 6, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106074 branch from 2950b38 to 7ae44f3 Compare July 6, 2023 00:35
@blathers-crl blathers-crl bot requested review from dt and rhu713 July 6, 2023 00:35
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 6, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@srosenberg srosenberg merged commit c93fc19 into release-23.1 Aug 1, 2023
6 checks passed
@srosenberg srosenberg deleted the blathers/backport-release-23.1-106074 branch August 1, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants