New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: cloud,backupccl: path does not contain a completed latest backup (emp… #106235
Conversation
…ty objects ending with /) Third-party services, e.g., AWS DataSync insert empty objects with a trailing `/` (to denote folders). Thus, a bucket containing backups which was transferred via AWS DataSync cannot be restored. Previously, restore would fail with the follwing error message, `read LATEST path: path does not contain a completed latest backup: NoSuchKey`. This change skips over the empty object while enumerating the objects in the `LatestHistoryDirectory`. Epic: none Fixes: #106070 Release note (bug fix): cloud buckets containing backups can now be copied via AWS DataSync and other third-party services which insert empty object with a trailing `/`. Previously, restore would fail with the follwing error message, `read LATEST path: path does not contain a completed latest backup: NoSuchKey`.
fa2d7f7
to
a335ed7
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
2950b38
to
7ae44f3
Compare
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Reminder: it has been 3 weeks please merge or close your backport! |
Backport 1/1 commits from #106074 on behalf of @srosenberg.
/cc @cockroachdb/release
…ty objects ending with /)
Third-party services, e.g., AWS DataSync insert empty objects with a trailing
/
(to denote folders). Thus, a bucket containing backups which was transferred via AWS DataSync cannot be restored.Previously, restore would fail with the follwing
error message,
read LATEST path: path does not contain a completed latest backup: NoSuchKey
.This change skips over the empty object while enumerating the objects in the
LatestHistoryDirectory
.Epic: none
Fixes: #106070
Release note (bug fix): cloud buckets containing backups can now be copied via AWS DataSync and other third-party services which insert empty object with a trailing
/
. Previously, restore would fail with the follwing error message,read LATEST path: path does not contain a completed latest backup: NoSuchKey
.Release justification: bug fix