Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg_class: populate pg_class.relreplident #106242

Merged
merged 1 commit into from Jul 10, 2023

Conversation

otan
Copy link
Contributor

@otan otan commented Jul 6, 2023

Release note (sql change): pg_class's relreplident field was previously unpopulated. It is now populated with d for all tables (as each table has a primary key) and n otherwise.

Informs: #84505

Release note (sql change): pg_class's relreplident field was
previously unpopulated. It is now populated with `d` for all tables (as
each table has a primary key) and n otherwise.
@otan otan requested a review from a team as a code owner July 6, 2023 05:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan requested a review from rafiss July 10, 2023 07:08
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though just one thing to consider - what about tables where the primary key is the hidden rowid column? does pgrepl work ok with that?

@otan
Copy link
Contributor Author

otan commented Jul 10, 2023

good question - it's unclear to me at the moment - but given that we display rowid as a primary key column on pg_catalog tables, i'm going to leave this "accurate" to that standard for now.

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Jul 10, 2023

Build succeeded:

@craig craig bot merged commit 33d9616 into cockroachdb:master Jul 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants