Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: fix CREATE AS sourcing vtable panics #106274

Merged
merged 4 commits into from Jul 6, 2023
Merged

release-23.1: sql: fix CREATE AS sourcing vtable panics #106274

merged 4 commits into from Jul 6, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Jul 6, 2023 •
edited

Backport 4/4 commits from #106203.

/cc @cockroachdb/release

Fixes #106166
Fixes #106167
Fixes #106168
Informs #105895

Fixes panics affects CREATE AS sourcing from vtables. These statements now work properly:

CREATE TABLE t AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;
CREATE TABLE t AS SELECT * FROM crdb_internal.create_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM crdb_internal.create_statements;

Release justification: Fix CREATE AS statement panics.

@ecwall
sql: fix CREATE AS sourcing pg_catalog.pg_prepared_statements panic
6fa86ad 
Fixes #106166

Fixes a bug discovered in #105895 that caused a panic when running these
statements because planner.preparedStatements was nil:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_prepared_statements;

Release note (bug fix): Fix panic executing CREATE AS with
pg_catalog.pg_prepared_statements source. For example:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_prepared_statements;
@ecwall
sql: fix CREATE AS sourcing pg_catalog.pg_cursors panic
328b1e7 
Fixes #106167

Fixes a bug discovered in #105895 that caused a panic when running these
statements because planner.sqlCursors was nil:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;

Release note (bug fix): Fix panic executing CREATE AS with
pg_catalog.cursors source. For example:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;
@ecwall
sql: fix CREATE AS sourcing crdb_internal.create_statements panic
c50c20e 
Fixes #106168

Fixes a bug discovered in #105895 that caused a panic when running these
statements because planner.semaCtx.NameResolver was nil:
CREATE TABLE t AS SELECT * FROM crdb_internal.create_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM crdb_internal.create_statements;

Release note (bug fix): Fix panic executing CREATE AS with
crdb_internal.create_statements source. For example:
CREATE TABLE t AS SELECT * FROM crdb_internal.create_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM crdb_internal.create_statements;
@ecwall
sql: remove TestCreateAsVTable brokenTables
0776ad6 
Informs #105895

Remove the broken tables map now that it is empty.

Release note: None
@ecwall ecwall requested a review from a team as a code owner July 6, 2023 14:00
@blathers-crl
Copy link

blathers-crl bot commented Jul 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall merged commit 95922c5 into cockroachdb:release-23.1 Jul 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ecwall @cockroach-teamcity @chengxiong-ruan