builtins: add pg_sequence_last_value builtin #106445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
pg_sequence_last_value
branch
from
42ab39f
to
17b36b7
Compare
michae2
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
pkg/sql/sequence.go line 371 at r1 (raw file):
// Before using for the first time, sequenceValue will be: // opts.Start - opts.Increment.
Can sequences wrap around?
rafiss
commented
Jul 12, 2023
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sequence.go line 371 at r1 (raw file):
Previously, michae2 (Michael Erickson) wrote…
Can sequences wrap around?
no, you'd get
ERROR: nextval(): reached maximum value of sequence "s"
SQLSTATE: 2200H
Release note (sql change): Added the pg_sequence_last_value builtin function, which returns the last value generated by the sequence.
rafiss
force-pushed
the
pg_sequence_last_value
branch
from
17b36b7
to
3758ae8
Compare
|
tftr! bors r=michae2 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #105957
Release note (sql change): Added the pg_sequence_last_value builtin function, which returns the last value generated by the sequence.