Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: flowinfra: clean up flow stats propagation in row-based flows #106597

Merged
merged 1 commit into from Jul 12, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 11, 2023

Backport 1/1 commits from #106546 on behalf of @yuzefovich.

/cc @cockroachdb/release


Previously, we would attach FlowStats (like max memory usage) to the "stream component" stats object. I don't really understand why that was the case, probably it was due to misunderstanding how tracing works (in particular, the TODOs that are now removed mentioned "flow level span", but we don't need to attach the metadata to a particular tracing span).

This simplifies the code a bit but also simplifies the work on adding region information to ComponentID object.

Epic: None

Release note: None


Release justification: low-risk cleanup.

Previously, we would attach `FlowStats` (like max memory usage) to the
"stream component" stats object. I don't really understand why that was
the case, probably it was due to misunderstanding how tracing works (in
particular, the TODOs that are now removed mentioned "flow level span",
but we don't need to attach the metadata to a particular tracing span).

This simplifies the code a bit but also simplifies the work on adding
region information to `ComponentID` object.

Release note: None
@blathers-crl blathers-crl bot requested review from a team as code owners July 11, 2023 16:32
@blathers-crl blathers-crl bot requested a review from yuzefovich July 11, 2023 16:32
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106546 branch from a39e96c to 4ac286b Compare July 11, 2023 16:32
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 11, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106546 branch from 5747cf3 to 9c4dce3 Compare July 11, 2023 16:32
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 11, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich
Copy link
Member

Backporting to aid in backporting of #106587.

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich yuzefovich merged commit 7bfb0ce into release-23.1 Jul 12, 2023
6 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-106546 branch July 12, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants