New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: flowinfra: clean up flow stats propagation in row-based flows #106597
release-23.1: flowinfra: clean up flow stats propagation in row-based flows #106597
Conversation
Previously, we would attach `FlowStats` (like max memory usage) to the "stream component" stats object. I don't really understand why that was the case, probably it was due to misunderstanding how tracing works (in particular, the TODOs that are now removed mentioned "flow level span", but we don't need to attach the metadata to a particular tracing span). This simplifies the code a bit but also simplifies the work on adding region information to `ComponentID` object. Release note: None
a39e96c
to
4ac286b
Compare
5747cf3
to
9c4dce3
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Backporting to aid in backporting of #106587. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Backport 1/1 commits from #106546 on behalf of @yuzefovich.
/cc @cockroachdb/release
Previously, we would attach
FlowStats
(like max memory usage) to the "stream component" stats object. I don't really understand why that was the case, probably it was due to misunderstanding how tracing works (in particular, the TODOs that are now removed mentioned "flow level span", but we don't need to attach the metadata to a particular tracing span).This simplifies the code a bit but also simplifies the work on adding region information to
ComponentID
object.Epic: None
Release note: None
Release justification: low-risk cleanup.