github-pull-request-make: stress if test was unskipped via skip pkg
#106921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unnecessary retries that were added because `yarn install` was flaky (we don't do `yarn install` as part of the build any more). Epic: none Release note: None Closes: cockroachdb#106914
rickystewart
added
the
backport-23.1.x
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rail
approved these changes
Jul 17, 2023
|
bors r=rail |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d9375ac to blathers/backport-release-23.1-106921: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Jul 19, 2023
...via `skip` pkg Backport 1/1 commit from cockroachdb#106921. Epic: none Release note: None Release justification: Test-only code change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove unnecessary retries that were added because
yarn installwas flaky (we don't doyarn installas part of the build any more).Epic: none
Release note: None
Closes: #106914