Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add a retry loop for stmts in READ COMMITTED txns #107044

Merged
merged 3 commits into from Aug 17, 2023

Commits on Aug 16, 2023

  1. sql: add a retry loop for stmts in READ COMMITTED txns

    This new loop retries individual statements inside an explicit READ
    COMMITTED transaction. This is possible because each statement in a READ
    COMMITTED transaction has a different read timestamp. The conn executor
    already has retry logic for all implicit transactions, and we continue to
    use those when possible.
    
    A session setting controls how many retries will be performed for a statement
    inside of an explicit READ COMMITTED transaction.
    
    Release note (sql change): Added the
    max_retries_for_read_committed session variable. It
    defaults to 10, and determines the number of times an individual
    statement in an explicit READ COMMITTED transaction will be retried
    if it encounters a retriable transaction error.
    rafiss committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    7f8f436 View commit details
    Browse the repository at this point in the history
  2. sql/tests: add a test for WriteTooOldError under READ COMMITTED

    Release note: None
    rafiss committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6ac84c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. sql: add a test for not doing retries if results were sent

    This test ensures that we do not do per-statement retries for READ
    COMMITTED transactions if results were already sent to the client.
    
    Release note: None
    rafiss committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0e57591 View commit details
    Browse the repository at this point in the history