Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: fix SHOW GRANTS when schema is offline #107238

Merged
merged 1 commit into from Jul 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 20, 2023

Backport 1/1 commits from #107229 on behalf of @rafiss.

/cc @cockroachdb/release


This issue also affected any usage of the information_schema.role_routine_grants table,
but that is probably too low-level to include in the release note.

fixes #106370
Release note (bug fix): Fixed a bug where SHOW GRANTS could fail if any objects were offline, which can happen during a RESTORE.


Release justification: bug fix

Release note (bug fix): Fixed a bug where SHOW GRANTS could fail if any
objects were offline, which can happen during a RESTORE.
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 20, 2023 05:39
@blathers-crl blathers-crl bot removed the request for review from a team July 20, 2023 05:39
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107229 branch from d62a2f3 to 40bca6f Compare July 20, 2023 05:39
@blathers-crl blathers-crl bot requested a review from rhu713 July 20, 2023 05:39
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 20, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107229 branch from 3a5ea2c to 3da57e2 Compare July 20, 2023 05:39
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from adityamaru, fqazi and a team July 20, 2023 05:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jarlva
Copy link

jarlva commented Jul 20, 2023

Also seeing the issue. Running 'show grants' errors with: ERROR: schema "public" is offline: restoring. I recently restored a database.
The following works:

SHOW GRANTS ON SCHEMA public
SHOW GRANTS ON SCHEMA my-db.public

Using CRDB 23.1.5

@rafiss
Copy link
Collaborator

rafiss commented Jul 21, 2023

@jarlva thanks for letting us know. The current plan is that the 23.1.7 release should include this fix.

@rafiss rafiss merged commit 6a810f6 into release-23.1 Jul 21, 2023
6 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.1-107229 branch July 21, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants