Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: fix CREATE TABLE AS schema change job description #107402

Merged
merged 3 commits into from Jul 24, 2023
Merged

release-22.2: sql: fix CREATE TABLE AS schema change job description #107402

merged 3 commits into from Jul 24, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 21, 2023 •
edited by ecwall

Backport 3/3 commits from #107367 on behalf of @ecwall.

/cc @cockroachdb/release

Fixes #107364

This changes the CREATE TABLE AS schema change job description to no longer incorrectly
include column types.
For example
CREATE TABLE movr.public.t2 (id INT8) AS SELECT * FROM movr.public.t;
becomes
CREATE TABLE movr.public.t2 (id) AS SELECT * FROM movr.public.t;

Release note (bug fix): Fix CREATE TABLE AS schema change job description SQL syntax.

Release justification: CTAS schema change job description fix.

@ecwall
sql: add type to FormatTypeReference error
db0468c 
Add the invalid type to the `type reference must implement NodeFormatter` error
to help with debugging.

Release note: None
@ecwall
sql: populate ColumnTableDef.Type conditionally
68a8bab 
Refactor `newTableDescIfAs` slightly to make it clear that `p.Defs` iteration
only happens if `p.Defs` is not empty.

Release note: None
@ecwall
sql: fix CREATE TABLE AS schema change job description
10b72aa 
Fixes #107364

This changes the CREATE TABLE AS schema change job description to no longer
incorrectly include column types.
For example
`CREATE TABLE movr.public.t2 (id INT8) AS SELECT * FROM movr.public.t;`
becomes
`CREATE TABLE movr.public.t2 (id) AS SELECT * FROM movr.public.t;`

Release note (bug fix): Fix CREATE TABLE AS schema change job description SQL syntax.
@blathers-crl blathers-crl bot requested review from a team as code owners July 21, 2023 22:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-107367 branch from 68a8bab to b2f81f9 Compare July 21, 2023 22:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 21, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-107367 branch from abffc64 to 10b72aa Compare July 21, 2023 22:36
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 21, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from ecwall and fqazi July 21, 2023 22:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

fqazi
fqazi approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ecwall)

@ecwall ecwall merged commit ee997cb into release-22.2 Jul 24, 2023
5 of 6 checks passed
@ecwall ecwall deleted the blathers/backport-release-22.2-107367 branch July 24, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqazi fqazi fqazi approved these changes

@ecwall ecwall Awaiting requested review from ecwall

Assignees

@ecwall ecwall

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @fqazi @ecwall