cli/zip: emit SQL table data using TSV by default #107474
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
i'll wait for CI to tell me which tests need updating. |
knz
force-pushed
the
20230724-debug-zip-tsv
branch
from
2068261
to
6a805f6
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @knz)
pkg/cli/testdata/zip/testzip_external_process_virtualization line 155 at r1 (raw file):
[node ?] ? log files found [node 1] [log file: ... [node 1] [log file: ...
nit: Just curious - what about this change impacted the test outputs such that we have these extra lines?
This is a partial revert of 35738d4. It changes the default value of the `--format` flag back from JSON to TSV. Release note (backward-incompatible change): THIS RELEASE NOTE CANCELS THE CORRESPONDING PREVIOUS BACKWARD-INCOMPATIBLE CHANGE. New behavior, compatible with previous versions of CockroachDB: the command `cockroach debug zip` stores data retrieved from SQL tables in the remote cluster using the TSV format by default. Release note (cli change): The default value of the `--format` parameter to `cockroach debug zip` is `tsv`, like other CLI commands that can extract SQL data.
knz
force-pushed
the
20230724-debug-zip-tsv
branch
from
6a805f6
to
38cf825
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/cli/testdata/zip/testzip_external_process_virtualization line 155 at r1 (raw file):
Previously, abarganier (Alex Barganier) wrote…
nit: Just curious - what about this change impacted the test outputs such that we have these extra lines?
This was actually some extra non-determinism we had there already (and thus possible source of flakes).
Fixed.
|
bors r=abarganier |
|
Build succeeded: |
Fixes #107473.
Epic: CRDB-28893
This is a partial revert of 35738d4.
It changes the default value of the
--formatflag back from JSON to TSV.Release note (backward-incompatible change):
THIS RELEASE NOTE CANCELS THE CORRESPONDING PREVIOUS BACKWARD-INCOMPATIBLE CHANGE. New behavior, compatible with previous versions of CockroachDB: the command
cockroach debug zipstores data retrieved from SQL tables in the remote cluster using the TSV format by default.Release note (cli change): The default value of the
--formatparameter tocockroach debug zipistsv, like other CLI commands that can extract SQL data.