kvserver: disable replicate queue and lease transfers in closedts tests #107531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
For a more holistic suggestion on how to fix this for the likely many other tests susceptible to similar issues, see: cockroachdb#107528 Fixes cockroachdb#101824. Release note: None Epic: none
tbg
force-pushed
the
TestClosedTimestampCantServeWithConflictingIntent
branch
from
6fc4e57
to
2c72155
Compare
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 25, 2023
Adopt setupClusterForClosedTSTesting which wraps setupClusterWithDummyRange with goodies such as cockroachdb#107531.
erikgrinaker
approved these changes
Jul 26, 2023
Yes, some of them do. I'll see if I can audit + maybe do the upreplication that is needed manually. But this affects like 20 tests I think, so I was shying away from that initially. |
|
Won't that have the same effect in practice? It also disables the split/merge queues, but otherwise it basically just disables the replicate queue. Not worth a long yak shave, but if it takes like 5 minutes then go for it. |
|
I'll take a look at this in #107533, where I'm also in the area. TFTR! bors r=erikgrinaker |
|
Build succeeded: |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jul 26, 2023
Adopt setupClusterForClosedTSTesting which wraps setupClusterWithDummyRange with goodies such as cockroachdb#107531.
craig bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
107525: rangefeed: add `BenchmarkRangefeed` r=erikgrinaker a=erikgrinaker Resolves #107440. Epic: none Release note: None 107533: kvserver: improve TestClosedTimestampFrozenAfterSubsumption r=erikgrinaker a=tbg Adopt setupClusterForClosedTSTesting which wraps setupClusterWithDummyRange with goodies such as #107531. Fixes #107179[^1] [^1]: #107179 (comment) Epic: None Release note: None Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
|
blathers backport 23.1 22.2 |
This was referenced Aug 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a more holistic suggestion on how to fix this for the likely many other
tests susceptible to similar issues, see:
#107528
Fixes #101824.
Release note: None
Epic: none