Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: warn when using https sink urls #107572

Merged
merged 2 commits into from Aug 2, 2023
Merged

changefeedccl: warn when using https sink urls #107572

merged 2 commits into from Aug 2, 2023

Commits on Jul 25, 2023

  1. changefeedccl: warn on when using https sink urls 

    Fixes cockroachdb#98719.

Release note: None
    @HonoreDB
    HonoreDB committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    922d6e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. changefeedccl: prepend file- to cloudstorage http(s) schemes 

    Changefeeds previously used http as their URI to align with backups.
Backups no longer support http, and for changefeeds http is ambiguous,
leading users to create cloudstorage sinks when they meant webhook sinks.
This commit changes the scheme to file-http. Webhooks still use webhook-http.

Informs: cockroachdb#98719

Release note (enterprise change): Changefeeds that create files over an http connection may now be specified via `INTO 'file-https://'` to disambiguate with `webhook-https`.
    @HonoreDB
    HonoreDB committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a428c45 View commit details
    Browse the repository at this point in the history