sql/catalog: add region_liveness table #107903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
regionLivenessTable
branch
2 times, most recently
from
b3f6fe4
to
51b470f
Compare
|
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers-crl
bot
added
O-community
fqazi
force-pushed
the
regionLivenessTable
branch
2 times, most recently
from
dcf4ca3
to
4c92325
Compare
fqazi
removed
O-community
fqazi
force-pushed
the
regionLivenessTable
branch
4 times, most recently
from
34b8589
to
85f347d
Compare
fqazi
force-pushed
the
regionLivenessTable
branch
4 times, most recently
from
db8ebf5
to
ee8733d
Compare
fqazi
force-pushed
the
regionLivenessTable
branch
from
ee8733d
to
25559bd
Compare
fqazi
force-pushed
the
regionLivenessTable
branch
from
25559bd
to
57d718f
Compare
Previously, we had no way of tracking region liveness which could can be used to improve behaviour on region failures. To address this, this patch introduces the system.region_liveness table. Epic: CRDB-28158 Informs: cockroachdb#103727 Release note: None
fqazi
force-pushed
the
regionLivenessTable
branch
2 times, most recently
from
e331c68
to
7d5efa7
Compare
JeffSwenson
reviewed
Aug 17, 2023
fqazi
force-pushed
the
regionLivenessTable
branch
from
7d5efa7
to
b156069
Compare
Previously, the region liveness table was only created for new clusters. This was inadequate because we need this table to be created for existing ones too. To address this, this patch adds a migration to create this table and clear its key space, since its been reused. Epic: CRDB-28158 Release note: None
fqazi
force-pushed
the
regionLivenessTable
branch
from
b156069
to
5ecf019
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new region_liveness table and a migration to create this table for existing clusters, allowing us to introduce the concept of region liveness in later PRs. This will allow certain system tables to be configured as SURVIVE REGION later on.
Epic: CRDB-28158