New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: changefeedccl: Correctly handle dropped UDTs #107943
release-22.1: changefeedccl: Correctly handle dropped UDTs #107943
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Almost clean backport; had to fix up the test for 22.1 and add main_test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava)
Schema feed is responsible for the determination of correct schema descriptor corresponding to an event occuring at certain time. Due to the need to use low level API to retrieve historical descriptor versions, it is possible that the schema feed would observe descriptors that were dropped/deleted/truncated. A long outstanding bug in schema feed would incorrectly check for low level value being 'nil' in order to determine if the descriptor was dropped. This check is incorrect since the iterator may return a non-nil empty byte array reprsenting a tombstone. A non-nil, but empty KV value would lead schema feed to incorrectly attempt to deserialize protocol message, resulting in a `value type is not BYTES: UNKNOWN` being returned. This PR fixes the above issue, and adds a test to verify correct behavior. Fixes https://github.com/cockroachlabs/support/issues/2408 Release note (enterprise change): Fix a rare changefeed issue which is triggered when the parent database or types are dropped, and instead of exiting with a descriptive error message, the changefeed would observe an opaque error instead (`value type is not BYTES: UNKNOWN`)
145f9eb
to
55738a0
Compare
Backport 1/1 commits from #107923.
/cc @cockroachdb/release
Schema feed is responsible for the determination
of correct schema descriptor corresponding to an
event occuring at certain time.
Due to the need to use low level API to retrieve
historical descriptor versions, it is possible that the schema feed would observe descriptors that were dropped/deleted/truncated.
A long outstanding bug in schema feed would
incorrectly check for low level value being 'nil' in order to determine if the descriptor was dropped.
This check is incorrect since the iterator may return a non-nil empty byte array reprsenting a tombstone.
A non-nil, but empty KV value would lead schema feed to incorrectly attempt to deserialize protocol message, resulting in a
value type is not BYTES: UNKNOWN
being returned.This PR fixes the above issue, and adds a test
to verify correct behavior.
Fixes https://github.com/cockroachlabs/support/issues/2408
Release note (enterprise change): Fix a rare changefeed issue which is triggered when the parent database or types are dropped, and instead of exiting with a descriptive error message, the changefeed would observe an opaque error instead (
value type is not BYTES: UNKNOWN
)Release justification: bug fix -- fix a long outstanding bug in changefeed.