Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: changefeedccl: Correctly handle dropped UDTs #107943

Merged
merged 1 commit into from Aug 1, 2023

Conversation

miretskiy
Copy link
Contributor

@miretskiy miretskiy commented Aug 1, 2023

Backport 1/1 commits from #107923.

/cc @cockroachdb/release


Schema feed is responsible for the determination
of correct schema descriptor corresponding to an
event occuring at certain time.

Due to the need to use low level API to retrieve
historical descriptor versions, it is possible that the schema feed would observe descriptors that were dropped/deleted/truncated.

A long outstanding bug in schema feed would
incorrectly check for low level value being 'nil' in order to determine if the descriptor was dropped.
This check is incorrect since the iterator may return a non-nil empty byte array reprsenting a tombstone.
A non-nil, but empty KV value would lead schema feed to incorrectly attempt to deserialize protocol message, resulting in a value type is not BYTES: UNKNOWN being returned.

This PR fixes the above issue, and adds a test
to verify correct behavior.

Fixes https://github.com/cockroachlabs/support/issues/2408

Release note (enterprise change): Fix a rare changefeed issue which is triggered when the parent database or types are dropped, and instead of exiting with a descriptive error message, the changefeed would observe an opaque error instead (value type is not BYTES: UNKNOWN)

Release justification: bug fix -- fix a long outstanding bug in changefeed.

@miretskiy miretskiy requested a review from a team as a code owner August 1, 2023 13:39
@miretskiy miretskiy requested review from shermanCRL and removed request for a team August 1, 2023 13:39
@blathers-crl
Copy link

blathers-crl bot commented Aug 1, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@miretskiy miretskiy requested a review from fqazi August 1, 2023 13:40
@miretskiy
Copy link
Contributor Author

Almost clean backport; had to fix up the test for 22.1 and add main_test.

@miretskiy miretskiy requested review from jayshrivastava and removed request for shermanCRL August 1, 2023 13:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava)

Schema feed is responsible for the determination
of correct schema descriptor corresponding to an
event occuring at certain time.

Due to the need to use low level API to retrieve
historical descriptor versions, it is possible that
the schema feed would observe descriptors that were
dropped/deleted/truncated.

A long outstanding bug in schema feed would
incorrectly check for low level value being 'nil' in order
to determine if the descriptor was dropped.
This check is incorrect since the iterator may return a
non-nil empty byte array reprsenting a tombstone.
A non-nil, but empty KV value would lead schema feed
to incorrectly attempt to deserialize protocol message,
resulting in a `value type is not BYTES: UNKNOWN` being
returned.

This PR fixes the above issue, and adds a test
to verify correct behavior.

Fixes https://github.com/cockroachlabs/support/issues/2408

Release note (enterprise change): Fix a rare changefeed
issue which is triggered when the parent database or types
are dropped, and instead of exiting with a descriptive error
message, the changefeed would observe an opaque error instead
(`value type is not BYTES: UNKNOWN`)
@miretskiy miretskiy merged commit 78554d1 into cockroachdb:release-22.1 Aug 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants