Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: ui: fix infinite cluster setting refresh #108125

Merged
merged 1 commit into from Aug 4, 2023
Merged

release-23.1: ui: fix infinite cluster setting refresh #108125

merged 1 commit into from Aug 4, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 3, 2023 •
edited by zachlite

Backport 1/1 commits from #108049 on behalf of @zachlite.

/cc @cockroachdb/release

The DatabaseTablePage was unconditionally refreshing cluster settings causing a flood of network requests.

Epic: none
Release note (bux fix): A bug has been fixed that caused a flood of requests to refresh cluster settings on the Table Detail page.

If a user would like to see the effect of a modified cluster setting in DB Console, a page-reload is required.

Release justification: bug fix

ui: fix infinite cluster setting refresh
88f5306 
The DatabaseTablePage was unconditionally refreshing cluster settings
causing a flood of network requests.

Epic: none
Release note (bux fix): A bug has been fixed that caused a flood of
requests to refresh cluster settings on the Table Detail page.

If a user would like to see the effect of a modified cluster setting
in DB Console, a page-reload is required.
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 3, 2023 16:24
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-108049 branch from 0476a36 to 66c3c26 Compare August 3, 2023 16:24
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 3, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-108049 branch from 022e09e to 88f5306 Compare August 3, 2023 16:24
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 3, 2023 •
edited by zachlite

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from THardy98 August 3, 2023 16:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@zachlite zachlite requested a review from a team August 4, 2023 14:33
maryliag
maryliag approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @THardy98)

@zachlite zachlite merged commit 05c70a2 into release-23.1 Aug 4, 2023
6 checks passed
@zachlite zachlite deleted the blathers/backport-release-23.1-108049 branch August 4, 2023 14:45
@cockroach-teamcity cockroach-teamcity mentioned this pull request Aug 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

@THardy98 THardy98 Awaiting requested review from THardy98

Assignees

@zachlite zachlite

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @maryliag @zachlite