sql: prevent panic when using UDF as EXECUTE argument #108213
Conversation
|
This change is |
|
I created #108215 to track allowing UDFs within EXECUTE arguments. |
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 2 of 0 LGTMs obtained (waiting on @mgartner)
-- commits line 9 at r1:
[nit] introduces -> introduced
There was a problem hiding this comment.
Reviewable status:
Previously, DrewKimball (Drew Kimball) wrote…
[nit]
introduces->introduced
Done.
mgartner
force-pushed
the
99008-udf-execute-panic
branch
2 times, most recently
from
d236963
to
22ba717
Compare
Fixes cockroachdb#99008 Release note (bug fix): A bug has been fixed that caused nodes to crash when attempting to `EXECUTE` a prepared statement with an argument that referenced a user-defined function. This bug was present since user-defined functions were introduced in version 22.2.
mgartner
force-pushed
the
99008-udf-execute-panic
branch
from
22ba717
to
20c43ab
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
|
Since #99008 was an error from 22.2, is this going to be backported? |
|
Yes, we should backport it. Thanks for calling that out @rafiss! |
|
blathers backport 22.2 23.1 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 20c43ab to blathers/backport-release-22.2-108213: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. error creating merge commit from 20c43ab to blathers/backport-release-23.1-108213: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
mgartner
added
backport-22.2.x
Fixes #99008
Release note (bug fix): A bug has been fixed that caused nodes to crash
when attempting to
EXECUTEa prepared statement with an argument thatreferenced a user-defined function. This bug was present since
user-defined functions were introduced in version 22.2.