Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: add show default privileges for grantee #108285

Merged
merged 1 commit into from Aug 11, 2023

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Aug 7, 2023

Backport 1/1 commits from #107953.

/cc @cockroachdb/release


Previously, SHOW DEFAULT PRIVILEGES [FOR <ROLE|USER|ALL ROLES>] statements were supported. However, support for finding default privileges for a grantee did not exist. This patch adds a new syntax for showing the default privileges that a grantee received.

Fixes: #107741
Epic: CRDB-25481

Release note (sql change): This adds a new syntax to SHOW DEFAULT PRIVILEGES, SHOW DEFAULT PRIVILEGES FOR GRANTEE <grantee>, that shows the default privileges that a grantee received.

Release justification: new syntax (additive-only) that displays default privileges for a grantee

@blathers-crl
Copy link

blathers-crl bot commented Aug 7, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom annrpom marked this pull request as ready for review August 7, 2023 17:19
@annrpom annrpom requested a review from a team as a code owner August 7, 2023 17:19
@annrpom annrpom added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Aug 8, 2023
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andyyang890)

Previously, `SHOW DEFAULT PRIVILEGES [FOR <ROLE|USER|ALL ROLES>]`
statements were supported. However, support for finding default privileges
for a grantee did not exist. This patch adds a new syntax for showing the
default privileges that a grantee received.

Fixes: cockroachdb#107741
Epic: CRDB-25481

Release note (sql change): This adds a new syntax to `SHOW DEFAULT
PRIVILEGES`, `SHOW DEFAULT PRIVILEGES FOR GRANTEE <grantee>`, that
shows the default privileges that a grantee received.
@annrpom annrpom merged commit 2dd06a4 into cockroachdb:release-23.1 Aug 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants