backupccl: hookup tracing aggregator events from the restore job #108359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
requested review from
lidorcarmel,
ericharmeling,
mgartner,
dt and
stevendanna
and removed request for
a team,
lidorcarmel,
ericharmeling and
mgartner
stevendanna
reviewed
Aug 16, 2023
Comment on lines
695
to
701
| msg, ok := event.(protoutil.Message) | ||
| if !ok { | ||
| // This should never happen but if it does skip the aggregated event. | ||
| log.Warningf(ctx, "event is not a protoutil.Message: %T", event) | ||
| return | ||
| } | ||
| data := make([]byte, msg.Size()) | ||
| if _, err := msg.MarshalTo(data); err != nil { | ||
| // This should never happen but if it does skip the aggregated event. | ||
| log.Warningf(ctx, "failed to unmarshal aggregated event: %v", err.Error()) | ||
| return | ||
| } |
There was a problem hiding this comment.
Perhaps this could be a method on bulkutil.TracingAggregatorEvent so that it can be shared?
There was a problem hiding this comment.
i made it a util method instead of putting it on the interface since all events would have the same impl
This change builds on top of cockroachdb#107994 and wires up each restore data processor to emit TracingAggregatorEvents to the job coordinator. These events are periodically flushed to files in the `job_info` table and are consumable via the DBConsole Job Details page. Fixes: cockroachdb#100126 Release note: None
adityamaru
force-pushed
the
wireup-ingestion-stats
branch
from
b0a7126
to
e89c74f
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
stevendanna
approved these changes
Aug 25, 2023
|
TFTR! bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on top of #107994 and wires up each restore
data processor to emit TracingAggregatorEvents to the job coordinator.
These events are periodically flushed to files in the
job_infotable and are consumable via the DBConsole Job Details page.
Fixes: #100126
Release note: None