release-23.1: sql: fix exec+audit logs for BEGIN, COMMIT, SET stmts #108411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @j82w and @mgartner)
|
FYI there is a failure on master with high vmodule due to this #108421. |
yuzefovich
changed the title
Release note (bug fix): Fixed a bug where BEGIN, COMMIT, SET, ROLLBACK, and SAVEPOINT statements would not be written to the execution or audit logs.
There was no need for this to live in the sessioninit cache. It just caused an extra dependency. Release note: None
We don't need this field, since it's only used in one conditional, and that check can be replaced by a direct check of the txn associated with the planner. Release note: None
rafiss
force-pushed
the
backport23.1-107912
branch
from
f94e9b7
to
961c885
Compare
rafiss
commented
Aug 9, 2023
There was a problem hiding this comment.
Reviewable status:
pkg/sql/conn_executor_exec.go line 906 at r6 (raw file):
// logged correctly. p.stmt = stmt p.extendedEvalCtx.Placeholders = oldPlaceholders
this incorporates the fix from #108461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3/3 commits from #107912.
/cc @cockroachdb/release
Epic: None
Release justification: bug fix
Release note (bug fix): Fixed a bug where BEGIN, COMMIT, SET, ROLLBACK, and SAVEPOINT statements would not be written to the execution or audit logs.